Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 196 #500

Merged
merged 250 commits into from
Jan 19, 2024
Merged

Release 196 #500

merged 250 commits into from
Jan 19, 2024

Conversation

roblo-cgi
Copy link
Contributor

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Greg Pascucci and others added 30 commits September 5, 2023 15:28
initial commit of intermediate ccfog start application page
aedb7f9
cleaned up css
ace5d4c
Merge branch 'main' of github.com:bcgov/EDUC-CCOF into feature/ccfri-…
e60d681 
…1562
reverted
550e2c0
added intermediate page code
3126e3e
@roblo-cgi
Update constants.js
642f26f 
updated url to be new-application
@roblo-cgi
Merge pull request #423 from bcgov/feature/ccfri-1562
d57917c 
Feature/ccfri 1562
Merge branch 'main' of github.com:bcgov/EDUC-CCOF into release-195
7b0fb4d
added fiscal year to messages
c56244f
@roblo-cgi
Merge pull request #430 from bcgov/feature/ccfri-2160
29577bc 
added fiscal year to messages
@vietle-cgi
Adding Fiscal year slider for Multi fiscal year
76ad577
@jenbeckett
Merge branch 'main' of https://github.com/bcgov/EDUC-CCOF into releas…
8ae39bc 
…e-196

main
@roblo-cgi
Merge branch 'main' of github.com:bcgov/EDUC-CCOF into release-196
5fb4cce
@roblo-cgi
Merge branch 'main' of github.com:bcgov/EDUC-CCOF into release-196
7baa713
@roblo-cgi
updates for multifiscal - loading application array
90b951d
@jenbeckett
update to allow for historical change requests across multi year
9eae335
@jenbeckett
Merge branch 'release-196-rlo' of https://github.com/bcgov/EDUC-CCOF …
f14b5d6 
…into release-196-jb

pull from rob
@jenbeckett
historical works with a list of application ID
7f6809b
@roblo-cgi
fixed reactiveness of map
dd4b8e0
@jenbeckett
Merge branch 'release-196-rlo' of https://github.com/bcgov/EDUC-CCOF …
5e0029a 
…into release-196-jb

fix from rob
@jenbeckett
wip
e0d6b7d
@jenbeckett
Merge pull request #441 from bcgov/main
8c5197e 
Pull main into release-196
@jenbeckett
multi year nav bar
5ec261b
@jenbeckett
merge from 196 branch
9642fd7
@jenbeckett
merge from 196 branch
c1d9d31
@vietle-cgi
move FiscalYearSlider to guiComponent folder
8165045
@vietle-cgi
Merge branch 'release-196' into release-195-Viet
842d634
@jenbeckett
tested for multi year
c412827
@jenbeckett
took out 1 thing
9c18926
@vietle-cgi
Message - fix bug and add scoped to style
2b38f6f
@jenbeckett
big update to allow renewal based on what's next in program year, not…
1ecac3f 
… what is set as renewal in ProgramYearList
@jenbeckett
added null checks in router
c4b2c1e
@jenbeckett
Merge pull request #496 from bcgov/release-196-jb6
02e8164 
Release 196 jb6
@jenbeckett
changed substring to replace
b02252f
@jenbeckett
Merge branch 'release-196' of https://github.com/bcgov/EDUC-CCOF into…
ad76fed 
… release-196

pull# Please enter a commit message to explain why this merge is necessary,
@jenbeckett
update wording
986e711
@jenbeckett
update code so facility does not keep saving post code
a249edd
@jenbeckett
post code update
31b0998
@jenbeckett
ccfri 3444 mapping for Ever applied for CCOF question incorrectly loa…
fef15b7 
…ding
@jenbeckett
fix renew button
cf0656f
@jenbeckett
more renewal button updates
9af943e
@jenbeckett
updates for Renewal button and CCOF status text
71278ff
@jenbeckett
fixed unlock not working for ccfri NEW fac CR, Update PCF button, add…
7aa8de8 
… facility ID on pages
@jenbeckett
remove
5faa31b
@jenbeckett
Merge pull request #497 from bcgov/release-196-jb7
0477ff4 
Release 196 jb7
@jenbeckett
Add program year label to months in Existing Fees Grid
b238673
@jenbeckett
Update ExistingFacilityFees.vue
fc00330
@jenbeckett
Added more validation on Closure Dates
06fbbe3
@jenbeckett
Update CurrentFeeVerification.vue date validations to run more
d44ac35
@jenbeckett
Merge pull request #498 from bcgov/jenbeckett-validation
247751f 
Jenbeckett validation
@jenbeckett
Update AddNewFees validation
f406510
@jenbeckett
Update CurrentFeeVerification.vue date validation
6a8361f
@jenbeckett
Made a facility header component to be re used across many pages disp…
2f990bc 
…laying facility name, ID, and license. Now they all look uniform. CCFRI 3466
@jenbeckett
spacing
82dfb81
@jenbeckett
Merge pull request #499 from bcgov/release-196-jb8
ca15976 
Add Facility Header component
@jenbeckett
Wording change addNewFees
f273c61
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

11 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

jenbeckett
jenbeckett approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@jenbeckett jenbeckett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@jenbeckett jenbeckett merged commit eb9a8ef into main Jan 19, 2024
8 of 11 checks passed
@jenbeckett jenbeckett deleted the release-196 branch January 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenbeckett jenbeckett jenbeckett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roblo-cgi @jenbeckett @vietle-cgi @chendongluo @poornimaaabhat