Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Source::parse arm for sparse repos (keeping it in the scheme). … #2950

Merged

Conversation

sthornington
Copy link
Contributor

@sthornington sthornington commented Oct 19, 2024

Proc macro resolution wasn't working properly for sparse repos. This fixes #2938.

Copy link

google-cla bot commented Oct 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sthornington
Copy link
Contributor Author

I wrote a test for it, but was unable to run it - cargo test seemed to want some runfiles stuff and looking at that in crates.io lead me to believe that these things are not able to be tested from within cargo.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

crate_universe/src/metadata/cargo_tree_resolver.rs Outdated Show resolved Hide resolved
@illicitonion illicitonion added this pull request to the merge queue Oct 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2024
@sthornington
Copy link
Contributor Author

Thanks, let me know if there is anything else for me to do to get this merged!

@illicitonion illicitonion added this pull request to the merge queue Oct 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2024
@illicitonion illicitonion added this pull request to the merge queue Oct 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2024
@illicitonion illicitonion added this pull request to the merge queue Oct 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2024
@illicitonion illicitonion added this pull request to the merge queue Oct 20, 2024
Merged via the queue into bazelbuild:main with commit 60141ec Oct 20, 2024
4 checks passed
@sthornington
Copy link
Contributor Author

Thanks everyone for getting this in. Can I ask for a point release which includes this, or when is 0.53.1 otherwise planned? Or can I do start it myself? Thanks again.

@sthornington sthornington deleted the simon_fix_sparse_repo_proc_macros branch October 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source::parse doesn't recognize sparse scheme?
2 participants