Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor main.go: improve flag handling and error validation #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

betrayalove
Copy link

-- Refactored flag handling by separating validation logic into functions for better clarity and structure.
-- Added validation for flags based on the type of network (with or without fault proofs).
-- Improved error handling by centralizing error checks and using log.Crit for consistent error reporting.
-- Simplified the withdrawal process by moving the logic for proof and finalization into a dedicated function (processWithdrawal).
-- Enhanced readability and maintainability by dividing code into smaller, purpose-specific functions.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants