-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sepolia] Fix withdrawal network for fee vaults #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to remove this record or we should keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it makes sense to keep it as a record
@@ -33,19 +33,19 @@ contract UpdateFeeVaultRecipient is Script { | |||
SequencerFeeVault sfvNew = new SequencerFeeVault( | |||
recipient, | |||
sfvOld.MIN_WITHDRAWAL_AMOUNT(), | |||
sfvOld.WITHDRAWAL_NETWORK() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fact that this is wrong means there's some wrong configuration in the genesis file? Is it somewhere in the OP repo where we set this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8ddbbdd
to
131eef3
Compare
Approved review 1857415616 from mdehoog is now dismissed due to new commit. Re-request for approval.
It turned out that the genesis fee vaults didn't have the correct value for withdrawal network, it should be L2 (1) instead of L1 (0). Thus updating the script to have the correct value.
Will need to rerun this script and verify the new contracts.
Performed a dry run and the script runs successfully
Change log to be approved: https://docs.google.com/document/d/1VTGKFdAq3BtoDPQMuH4E47g0t0u9H_fi1eo1RJMFOn8/edit?usp=sharing