Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Integrate Client generation for the Bal build command #1597

Closed
wants to merge 34 commits into from
Closed

[master] Integrate Client generation for the Bal build command #1597

wants to merge 34 commits into from

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Jan 24, 2024 •
edited
Loading

lnash94 and others added 26 commits October 13, 2023 21:27
@lnash94
Provide bal pre-build tool support
a4d3f85
@lnash94
Add client integration to the bal-task.
78b399f
@lnash94
Add bal task support for client generations
fc2c93d
@lnash94
Change the module name into generic bal task module.
913b501
@lnash94
Add tests
b640089
@lnash94
Fix default behaviour
f01ebde
@lnash94
Fix spotbugs issue
ebeba6c
@lnash94
Remove unused dependency
367368f
@lnash94
Add the subcommand add to the package build
06bd421
@lnash94
Fix review suggestions
a0923a8
@lnash94
Fix review suggestions
65cded7
@lnash94
Add newLine for os depend
ddb4028
@lnash94
Merge branch 'client-bal-task' of https://github.com/lnash94/ballerin…
131e1db 
…a-openapi into cache_handling
@lnash94
Add cache validation
cd96685
@lnash94
Merge pull request #1569 from lnash94/client-bal-task
0220f30 
[bal-build-task]Integrate OpenAPI Client generation to Ballerina package build
@lnash94
fix spot-bug changes
965b133
@lnash94
Align new plugin changes
6d05f1f
@lnash94
Fix review suggestions
55952e8
@lnash94
Add the subcommand add to the package build
72a66ee
@lnash94
Add newLine for os depend
f4ed6ca
@lnash94
Add success message for plugin update
51677be
@lnash94
Merge pull request #1576 from lnash94/cmd_client_bal_task
1986369 
[bal-build-task] Implement  `add` command for updating Ballerina.toml with openapi tool config element
@lnash94
Merge branch 'bal-build-task' of https://github.com/ballerina-platfor…
e272dec 
…m/openapi-tools into all-build-tool

# Conflicts:
#	openapi-cli/src/main/java/io/ballerina/openapi/cmd/Add.java
#	openapi-cli/src/main/java/io/ballerina/openapi/cmd/ErrorMessages.java
@lnash94
Fix review suggestions
419837b
@lnash94
Merge pull request #1591 from lnash94/cache_handling
ff8fcbe 
[bal-build-task]Fix for cache handling to openapi tool bal build integration
@lnash94
Merge branch 'bal-build-task' of https://github.com/ballerina-platfor…
558937c 
…m/openapi-tools into all-build-tool
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.16529% with 338 lines in your changes are missing coverage. Please review.

Project coverage is 78.27%. Comparing base (b49a2fd) to head (9eeb194).

❗ Current head 9eeb194 differs from pull request most recent head b5c0b09. Consider uploading reports for the commit b5c0b09 to get more accurate results

Files Patch % Lines
...ina/openapi/bal/tool/OpenAPICodeGeneratorTool.java 0.00% 220 Missing ⚠️
...li/src/main/java/io/ballerina/openapi/cmd/Add.java 57.34% 46 Missing and 15 partials ⚠️
...main/java/io/ballerina/openapi/cmd/OpenApiCmd.java 29.78% 18 Missing and 15 partials ⚠️
.../java/io/ballerina/openapi/bal/tool/Constants.java 0.00% 19 Missing ⚠️
.../core/generators/client/model/OASClientConfig.java 40.00% 3 Missing ⚠️
...main/java/io/ballerina/openapi/cmd/CmdOptions.java 97.72% 1 Missing ⚠️
...re/generators/client/BallerinaClientGenerator.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1597      +/-   ##
============================================
- Coverage     80.86%   78.27%   -2.59%     
+ Complexity     1954     1860      -94     
============================================
  Files           154      149       -5     
  Lines         10123    10242     +119     
  Branches       1658     1648      -10     
============================================
- Hits           8186     8017     -169     
- Misses         1361     1641     +280     
- Partials        576      584       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lnash94
Copy link
Member Author

lnash94 commented Feb 1, 2024

PRs:

@github-actions GitHub Actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Feb 16, 2024
@lnash94 lnash94 removed the Stale label Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@lnash94 lnash94 removed the Stale label Mar 6, 2024
lnash94 and others added 4 commits March 7, 2024 16:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lnash94 lnash94 mentioned this pull request Mar 11, 2024
Merged
@lnash94
Copy link
Member Author

lnash94 commented Mar 13, 2024

Close this PR with favour of #1616

@lnash94 lnash94 closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneshk daneshk Awaiting requested review from daneshk daneshk will be requested when the pull request is marked ready for review daneshk is a code owner

@TharmiganK TharmiganK Awaiting requested review from TharmiganK TharmiganK will be requested when the pull request is marked ready for review TharmiganK is a code owner

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar will be requested when the pull request is marked ready for review shafreenAnfar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include client generation to build command
1 participant
@lnash94