Getting started links #62
Conversation
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Change log | |||
|
|
|||
| * Update the resin-yocto-scripts submodule to 6f7a9ab326bb822196e3e48b08ef1d73d08caec6 (on master branch) [Florin] | |||
| * Use the new offsets for u-boot env and Trusted Zone binary blob that our new u-boot (version 2017.09) expects [Florin] | |||
| * Update getting starting links [Zach] | |||
There was a problem hiding this comment.
@zwalchuk this needs to sit on top; new additions to changelog are added on top
There was a problem hiding this comment.
Also, please change the commit log to be like:
CHANGELOG: Update getting started links
| linux: 'http://docs.resin.io/#/pages/installing/gettingStarted-ODROID-C1.md#on-mac-and-linux' | ||
| windows: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' | ||
| osx: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' | ||
| linux: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' |
There was a problem hiding this comment.
Commit log should be instead like:
odroid-c1.coffee: Update getting started links
Make sure getting started links match the appropriate getting started guides.
| linux: 'http://docs.resin.io/#/pages/installing/gettingStarted-ODROID-XU4.md#on-mac-and-linux' | ||
| windows: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' | ||
| osx: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' | ||
| linux: 'https://docs.resin.io/installing/gettingStarted-Odroid-C1/#creating-your-first-application' |
There was a problem hiding this comment.
The commit log needs to be like the following:
odroid-xu4.coffee: Update XU4 getting started links
|
This PR also needs rebasing |
Make sure getting started links match the appropriate getting started guides.
zwalchuk
force-pushed
the
getting-started-links
branch
from
51daa3b
to
50eb336
Compare
|
@resin-jenkins add to whitelist |
|
@zwalchuk can you rebase this? There seems to be an issue with how you rebased last time |
|
@floion These links are all going to be changing again today or early next week, I'm going to close this PR and start over doing it correctly when the new links are live |
Update getting started links for Odroid C1 and XU4
Connects to #44