Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #4224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ approach"][lego-blocks].

This has the advantage of allowing other applications to re-use logic we
implemented for Etcher in their own project, even for things we didn't expect,
which leads to users benefitting from what we've built, and we benefitting from
which leads to users benefiting from what we've built, and we're benefiting from
user's bug reports, suggestions, etc, as an indirect way to make Etcher better.

The fact that low-level details are scattered around many different modules can
make it challenging for a new contributor to wrap their heads around the
project as a whole, and get a clear high level view of how things work or where
project as a whole, and get a clear high-level view of how things work or where
to submit their work or bug reports.

These are the main Etcher components, in a nutshell:
Expand Down
2 changes: 1 addition & 1 deletion docs/PUBLISHING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Release Types

Etcher supports **pre-release** and **final** release types as does Github. Each is
published to Github releases.
The release version is generated automatically from the commit messasges.
The release version is generated automatically from the commit messages.

Signing
-------
Expand Down
2 changes: 1 addition & 1 deletion lib/shared/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export function getTitle(error: ErrorWithPath): string {
return `Error code: ${code}`;
}

return 'An error ocurred';
return 'An error occurred';
}

/**
Expand Down
12 changes: 6 additions & 6 deletions tests/shared/errors.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Shared: Errors', function () {
it('should return a generic error message if the error is an empty object', function () {
const error = {};
// @ts-ignore
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should return the error message', function () {
Expand Down Expand Up @@ -129,29 +129,29 @@ describe('Shared: Errors', function () {
const error = new Error();
// @ts-ignore
error.code = '';
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should not display a blank string error code', function () {
const error = new Error();
// @ts-ignore
error.code = ' ';
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should return a generic error message if no information was found', function () {
const error = new Error();
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should return a generic error message if no code and the message is empty', function () {
const error = new Error('');
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should return a generic error message if no code and the message is blank', function () {
const error = new Error(' ');
expect(errors.getTitle(error)).to.equal('An error ocurred');
expect(errors.getTitle(error)).to.equal('An error occurred');
});

it('should rephrase an ENOENT error', function () {
Expand Down
Loading