Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushed mongodb native package to v3.0 #468

Closed
wants to merge 1 commit into from

Conversation

Freundschaft
Copy link

hey there,

I updated the package to use mongodb native 3.0, so sails users can make use of the new mongodb 3.6 version. I choose to not completely rewrite everything so that it matches the new mongoclient logic, but instead attached the mongoclient object to the manager as the client attribute so it can be accessed.

for the changes introduced in mongodb native driver 3.0 see https://github.com/mongodb/node-mongodb-native/blob/3.0.0/CHANGES_3.0.0.md

Please review and merge if suitable

@gil0mendes
Copy link

This change is really interesting to support the more recent protocol mongodb+srv. Now that mLab is going away MongoDB Atlas uses a replica set even for the free server.

@DominusKelvin
Copy link
Collaborator

Hey @Freundschaft and @gil0mendes, I'll be closing this PR as this other PR has implemented the upgrade and it has been merged. Thank you for working on this @Freundschaft 💙

Also you can check here for the upgrade information. 👇🏾

https://blog.sailscasts.com/sails-mongo-v2-1-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants