Fixes : (#326)

- Easter day calculation rounding for the lunar correction when not using calendar extension - Added some phpunit test that checks cases that were incorrect before
azuyalabs · Dec 3, 2023 · 404b641 · 404b641
1 parent 8d67a7a
commit 404b641
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/Yasumi/Provider/ChristianHolidays.php b/src/Yasumi/Provider/ChristianHolidays.php
@@ -358,7 +358,7 @@ protected function calculateEaster(int $year, string $timezone): \DateTimeInterf
                 }
 
                 $solar = (int) (($year - 1600) / 100) - (int) (($year - 1600) / 400); // The solar correction
-                $lunar = (int) (($year - 1400) / 100 * 8 / 25); // The lunar correction
+                $lunar = (int) (((int) (($year - 1400) / 100) * 8) / 25); // The lunar correction
 
                 $pfm = (3 - (11 * $golden) + $solar - $lunar) % 30; // Uncorrected date of the Paschal full moon
             }

diff --git a/tests/Belgium/EasterTest.php b/tests/Belgium/EasterTest.php
@@ -41,6 +41,13 @@ public function testEaster(): void
             $year,
             new \DateTime("{$year}-4-4", new \DateTimeZone(self::TIMEZONE))
         );
+        $year = 2025;
+        $this->assertHoliday(
+            self::REGION,
+            self::HOLIDAY,
+            $year,
+            new \DateTime("{$year}-4-20", new \DateTimeZone(self::TIMEZONE))
+        );
     }
 
     /**

diff --git a/tests/France/EasterMondayTest.php b/tests/France/EasterMondayTest.php
@@ -41,6 +41,13 @@ public function testEasterMonday(): void
             $year,
             new \DateTime("{$year}-3-28", new \DateTimeZone(self::TIMEZONE))
         );
+        $year = 2025;
+        $this->assertHoliday(
+            self::REGION,
+            self::HOLIDAY,
+            $year,
+            new \DateTime("{$year}-4-21", new \DateTimeZone(self::TIMEZONE))
+        );
     }
 
     /**