update for kzg #70
Open
update for kzg #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking - is this ready for review? If not just let me know and request a review when you're ready. |
|
@jonathanpwang It is not yet, but will be by Monday! |
|
General structure for these contributions:
Context & reasoning for our design decisions in https://hackmd.io/PYBgxKM6T3CX_vQ63alfSA?both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General structure for these contributions:
KZGChip in halo2-ecc/src/commitments/kzg.rs. Tests for this in halo2-ecc/src/commitments/tests. Utility classes in halo2-ecc/src/commitments/utils for making KZG vector commitments and dealing with polynomials.
PolyChip in halo2-ecc/src/fields/poly.rs for poly evals
Selectable trait for fp2 in halo2-ecc/src/fields/fp2.rs and halo2-ecc/src/fields/vector.rs
Context & reasoning for our design decisions in https://hackmd.io/PYBgxKM6T3CX_vQ63alfSA?both.
authors: @lyronctk @punwai