Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
secp256r1
is a widely used elliptic curve. Axiom's halo2-lib provides an implementation ofsecp256k1
. At present,ec_double
andcheck_is_on_curve
inhalo2-ecc
ignore theax
term iny^2 = x^3 + ax + b
becausesecp256k1
does not need this term. To make their implementation more generalized and support more curves such assecp256r1
, this PR fixesec_double
andcheck_is_on_curve
and adds an implementation ofsecp256r1
.Test
cargo test --package halo2-ecc --lib -- secp256r1::tests::ecdsa::test_secp256r1_ecdsa --exact --nocapture