Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove librpma engine as librpma library is no longer maintained #1811

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Aug 29, 2024

Remove librpma engines as the librpma library project has been archived on GitHub.

Please confirm that your commit message(s) follow these guidelines:

  1. First line is a commit title, a descriptive one-liner for the change
  2. Empty second line
  3. Commit message body that explains why the change is useful. Break lines that
    aren't something like a URL at 72-74 chars.
  4. Empty line
  5. Signed-off-by: Real Name real@email.com

Reminders:

  1. If you modify struct thread_options, also make corresponding changes in
    cconv.c and bump FIO_SERVER_VER in server.h
  2. If you change the ioengine interface (hooks, flags, etc), remember to bump
    FIO_IOOPS_VERSION in ioengines.h.

Remove librpma support as rpma project is already archived:
https://github.com/pmem/rpma

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@@ -54,8 +54,7 @@ DPKGCFG
libiscsi-dev
libnbd-dev
libpmem-dev
libpmem2-dev
libprotobuf-c-dev
libpmemblk-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring libpmemblk-dev here seems unnecessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fio.1 Outdated
@@ -2431,7 +2431,7 @@ The TCP or UDP port to bind to or connect to. If this is used with
this will be the starting port number since fio will use a range of
ports.
.TP
.BI (rdma,librpma_*)port \fR=\fPint
.BI (rdma)port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this bit: \fR=\fPint still makes sense. Please consider keeping it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 changed the title Remove librpma engine as librpma library is no longer maintaied Remove librpma engine as librpma library is no longer maintained Aug 29, 2024
@vincentkfu
Copy link
Collaborator

I have looked through this and see no issues, but we are having a long weekend in the US, so I will wait until Tuesday to merge.

@axboe axboe merged commit 5d78927 into axboe:master Sep 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants