Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide link to bottlerocket for bare metal deprecation notice #8262

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaradtke-aws
Copy link
Member

Issue #, if available:
Provide link to bottlerocket for bare metal deprecation notice

@csplinter posted that bottlerocket is being deprecated as a supported method for bare metal as of EKS-A v0.19 (2024-02-29)
The EKS-A documentation should also reflect that change. Bottlerocket is still viable for previous versions which are still supported, therefore references to bottlerocket and bare metal should not yet be removed - and instead just provide guidance for the change.

Description of changes:
Provide a link to the github issue #7754 to guide the reader

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csplinter for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (8ab221a) to head (d2b927a).
Report is 274 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8262      +/-   ##
==========================================
- Coverage   73.38%   72.40%   -0.98%     
==========================================
  Files         578      578              
  Lines       35995    45373    +9378     
==========================================
+ Hits        26415    32853    +6438     
- Misses       7906    10790    +2884     
- Partials     1674     1730      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Removing redundant reference

Co-authored-by: Saurabh Parekh <saurabhparekh99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants