Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the documentation for ConnectionLimit to fix #1653 #3524

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

gcbeattyAWS
Copy link
Contributor

@gcbeattyAWS gcbeattyAWS commented Oct 21, 2024

Description

Updates the documentation for ConnectionLimit to fix #1653. Please note that this updates the https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/Runtime/TClientConfig.html value instead of the S3 specific one mentioned in https://docs.aws.amazon.com/sdkfornet/v3/apidocs/?page=TS3Config.html&tocid=Amazon_S3_AmazonS3Config from #1653

Motivation and Context

Testing

  1. Ran doc generator locally and then ran web server to verify the docs are updated. See attached screenshot
  2. Dry-Run build 1a36b7d6-7430-42ab-b1ef-8083c95365fb

Screenshots (if appropriate)

Screenshot 2024-10-18 175007

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@gcbeattyAWS gcbeattyAWS marked this pull request as ready for review October 21, 2024 21:00
@gcbeattyAWS gcbeattyAWS assigned philasmar and unassigned philasmar Oct 22, 2024
@gcbeattyAWS gcbeattyAWS merged commit 93ef40b into main-staging Oct 22, 2024
1 check passed
@dscpinheiro dscpinheiro deleted the gcbeatty/docupdate branch October 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants