Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InternalSDKUtils AOT compatible in V4 #3516

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Oct 16, 2024

Description

In AWSSDK.Core 3.7.400.35 InternalSDKUtils was made AOT compatible by obsoleting InternalSDKUtils.ApplyValues and creating a new method InternalSDKUtils.ApplyValuesV2, which is AOT compatible. This PR removes the obsolete method in V4 and refactors existing methods to use V2 similar to in V3. Thanks @Dreamescaper for the suggestion!

Motivation and Context

Fixes #3497 in V4

Testing

Created a console app with set to true and published the console app and no warnings appeared. I even ran the .exe and it worked.

DRY_RUN passes

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@peterrsongg peterrsongg merged commit 5de9e0e into v4-development Oct 17, 2024
1 check passed
@peterrsongg peterrsongg deleted the petesong/v4-dotnet-7768 branch October 17, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants