Adds TryAddDefaultAWSOptions to AWSSDK.Extensions.NETCore.Setup #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce TryAddDefaultAWSOptions methods to ServiceCollectionExtensions for adding AWSOptions without overriding existing registrations. Add unit tests to verify the new methods' behavior. Enhance dependency injection setup for AWS services with added flexibility and robustness.
2 tasks
ashishdhingra
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3481
Description
Microsoft.Extensions.DependencyInjection.ServiceCollectionExtensions.AddDefaultAWSOptionsalways registersAWSOptionseven if there was a previous registration.Motivation and Context
Code using does not need to worry if the options have already been registered.
Testing
Unit tests added.
Types of changes
Checklist
License