Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Upgrade Langchain, AWS Powertools, Pydantic. Fix config without default embedding and step function deployment. #598

Merged

Conversation

charles-marion
Copy link
Collaborator

@charles-marion charles-marion commented Oct 29, 2024

Issue #, if available: #596

Description of changes:

In #596 , the Step function prevents deployment because the account has reach the number of policies. See here
https://docs.aws.amazon.com/step-functions/latest/dg/sfn-best-practices.html#bp-cwl

The fix is to set the prefix of the log group names (/aws/vendedlogs/) so step function uses statement for all..

In #592, the CDK synth fails when there is no default embedding model (only needed when using Aurora/Opensearch).
Removed the check (since it's a valid use case) and verified the Embedding page is still working without default model.

Dependencies updates:
Because the build workflow fails due to a vulnerabilities in Langchain (https://github.com/aws-samples/aws-genai-llm-chatbot/security/dependabot/73), I upgraded the following

  • Langchain: Guide
  • Because it conflicts with Langchain, I also had to upgrade AWS Power tools
  • Because both the above require a new version of pydantic, I also upgraded it. In this case, the project uses it mostly for validator which has a new bahevior for optional values. (Guide)

Testing
Manual testing + Integration test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@surukonda
Copy link
Contributor

@charles-marion please make this change in lib/rag-engines/workspaces/delete-document.ts as well.

@charles-marion
Copy link
Collaborator Author

@charles-marion please make this change in lib/rag-engines/workspaces/delete-document.ts as well.

done

@charles-marion charles-marion changed the title bug: Set Step function log group prefix + fix deployment when not def… bug: Upgrade Langchain, AWS Powertools, Pydantic. Fix config without default embedding and step function deployment. Oct 30, 2024
@charles-marion charles-marion merged commit bd520f6 into aws-samples:main Oct 31, 2024
1 check passed
@charles-marion charles-marion deleted the bug_step_function_and_cli branch October 31, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants