Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix cli script when RAG is not enabled #594

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

charles-marion
Copy link
Collaborator

Issue #, if available: #592

Description of changes:

Fixes the following:

  • When RAG is disabled, the script should not try to set a default embedding model since there are none. (It was causing the failure in the issue above)
  • Updated the wording enableSagemakerModels since it refers to only text generation models at this time.
  • Fixed defaultEmbedding check. It should show a warning if a SageMaker embedding model is selected but none is available.
  • Fixed BedRock KB always enabled (even when there is none)
  • Fixed asking for a Kendra external index when it's disabled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@charles-marion charles-marion merged commit 23d4da3 into aws-samples:main Oct 22, 2024
1 check passed
@charles-marion charles-marion deleted the bug_cli branch October 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants