Skip to content

Commit

Permalink
Merge pull request #546 from aws-samples/fix/display-empty-azure-models
Browse files Browse the repository at this point in the history
fix: Models dropdown shows azure:openai even if no models have been configured
  • Loading branch information
grinko authored Aug 14, 2024
2 parents 8531e5d + 1f62e2e commit 99d2a38
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/guide/deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ cd aws-genai-llm-chatbot
**Step 3.** <a id="deployment-dependencies-installation"></a> Install the project dependencies and build the project.

```bash
npm install && npm run build
npm ci && npm run build
```

**Step 4.** (Optional) Run the unit tests
Expand All @@ -115,7 +115,7 @@ npm run config

You'll be prompted to configure the different aspects of the solution, such as:

- The LLMs or MLMs to enable (we support all models provided by Bedrock along with SageMaker hosted Idefics, FalconLite, Mistral and more to come).
- The LLMs or MLMs to enable (we support all models provided by Bedrock that [were enabled](https://docs.aws.amazon.com/bedrock/latest/userguide/model-access.html) along with SageMaker hosted Idefics, FalconLite, Mistral and more to come).
- Setup of the RAG system: engine selection (i.e. Aurora w/ pgvector, OpenSearch, Kendra).
- Embeddings selection.
- Limit accessibility to website and backend to VPC (private chatbot).
Expand Down Expand Up @@ -165,7 +165,7 @@ GenAIChatBotStack.ApiKeysSecretNameXXXX = ApiKeysSecretName-xxxxxx
**Step 11.** Login with the user created in **Step 8** and follow the instructions.

**Step 12.** (Optional) Run the integration tests
The tests require to be authenticated against your AWS Account because it will create cognito users. In addition, the tests will use `anthropic.claude-instant-v1` and `amazon.titan-embed-text-v1` which need to be enabled in Bedrock.
The tests require to be authenticated against your AWS Account because it will create cognito users. In addition, the tests will use `anthropic.claude-instant-v1` (Claude Instant) and `amazon.titan-embed-text-v1` (Titan Embeddings G1 - Text) which need to be enabled in Bedrock.

To run the tests (Replace the url with the one you used in the steps above)
```bash
Expand Down
3 changes: 2 additions & 1 deletion lib/shared/layers/python-sdk/python/genai_core/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ def list_azure_openai_models():
# azure openai model are listed, comma separated in
# AZURE_OPENAI_MODELS variable in external API secret
models = genai_core.parameters.get_external_api_key("AZURE_OPENAI_MODELS") or ""

if not models:
return None
return [
{
"provider": Provider.AZURE_OPENAI.value,
Expand Down

0 comments on commit 99d2a38

Please sign in to comment.