Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-light/facemovementonly challenge support #131

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thisisabhash
Copy link
Member

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 44.20601% with 130 lines in your changes missing coverage. Please review.

Project coverage is 31.63%. Comparing base (d7147fc) to head (bd97059).
Report is 3 commits behind head on main.

Files Patch % Lines
...ess/Views/Liveness/FaceLivenessDetectionView.swift 3.70% 52 Missing ⚠️
...s/Views/Instruction/InstructionContainerView.swift 0.00% 19 Missing ⚠️
...iews/Liveness/FaceLivenessDetectionViewModel.swift 48.38% 16 Missing ⚠️
...etectionViewModel+FaceDetectionResultHandler.swift 25.00% 12 Missing ⚠️
...ction/BlazeFace/FaceDetectorShortRange+Model.swift 0.00% 8 Missing ⚠️
...ceLiveness/Views/LoadingPage/LoadingPageView.swift 0.00% 7 Missing ⚠️
...Liveness/Views/GetReadyPage/GetReadyPageView.swift 0.00% 5 Missing ⚠️
...veness/Views/Liveness/LivenessViewController.swift 0.00% 5 Missing ⚠️
...nessDetectionViewModel+VideoSegmentProcessor.swift 0.00% 2 Missing ⚠️
...Liveness/Views/Liveness/LivenessStateMachine.swift 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   30.44%   31.63%   +1.18%     
==========================================
  Files          57       58       +1     
  Lines        2230     2412     +182     
==========================================
+ Hits          679      763      +84     
- Misses       1551     1649      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat: add no light challenge implementation

* update package.swift for CI build

* Fix unit tests

* Address review comments
* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant