Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Kover plugin #64

Merged
merged 3 commits into from
Jul 24, 2023
Merged

chore: Add Kover plugin #64

merged 3 commits into from
Jul 24, 2023

Conversation

mattcreaser
Copy link
Member

Issue #, if available:

Description of changes:

  • Applies Kover plugin for generating code coverage.
    • Merged report can be generated with e.g. ./gradlew koverHtmlReport
    • Component's coverage can be generated with e.g. ./gradlew :authenticator:koverHtmlReport

How did you test these changes?

  • Generated coverage reports

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners July 21, 2023 17:52
tjleing
tjleing previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the command to run Kover to the README.md or CONTRIBUTING.md?

gpanshu
gpanshu previously approved these changes Jul 21, 2023
View reviewed changes
Base automatically changed from mattcreaser/gradle-8 to main July 21, 2023 22:52
@mattcreaser mattcreaser dismissed stale reviews from gpanshu and tjleing July 21, 2023 22:52

The base branch was changed.

@mattcreaser mattcreaser added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 8ea0a16 Jul 24, 2023
1 check passed
@mattcreaser mattcreaser deleted the mattcreaser/kover-plugin branch July 24, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjleing tjleing tjleing approved these changes

@sdhuka sdhuka sdhuka approved these changes

@gpanshu gpanshu gpanshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattcreaser @tjleing @sdhuka @gpanshu