-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor host dmesg verification into a Setuper #3994
Refactor host dmesg verification into a Setuper #3994
Conversation
Hi @YongxueHong, Yet another Note that I'm also renaming one of the I guess there might be some concerns about changing the What do you think about that? Are you okay with that? should we rather create another submodule under Thanks a lot! |
Hi @bgartzi
Regarding the
|
Looking back at this, I agree with you.
It will just make the test fail if unexpected kernel messages are found, so they are notified and investigated. I'm separating both. I will move |
Host dmesg can be checked if the test configuration requires to do so. It will be in fact be checked both before and after running the test. However, that was done directly in the preprocess and postprocess functions in virttest.env_process. Write a Setuper subclass that implements those in setup/cleanup methods and register the setuper in the env_process setup_manager. Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
fa3145d
to
2894cc5
Compare
The main goal of this patch is to add a new
Setuper
subclass namedVerifyHostDMesg
, then use it in theenv_process
{pre,post}process
methodssetup_manager
.Meanwhile, I'm renaming the
virttest.test_setup.os_posix.py
file intovirttest.test_setup.host_config
, as that would help maintaining the number of submodules undervirttest.test_setup
under a reasonable amount.ID: 2437