Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86_cpu_models: update cpu models category #3974

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

nanliu-r
Copy link
Contributor

@nanliu-r nanliu-r commented Aug 20, 2024

ID: 3974

Need to add versioned CPU models into category

@nanliu-r nanliu-r marked this pull request as ready for review September 4, 2024 05:30
@nanliu-r nanliu-r force-pushed the fix_xsave_issue_for_amd branch 9 times, most recently from 1403686 to 510dcb4 Compare September 24, 2024 12:23
Need to add versioned CPU models into category

Signed-off-by: nanliu <nanliu@redhat.com>
@nanliu-r
Copy link
Contributor Author

For AMD, will add the versioned CPU models for EPYC and newer.

For Intel, will add the versioned CPU models for Icelake and newer, except CPU model "Snowridge" which has been deprecated since rhel10.

  • Based on fix: https://bugzilla.redhat.com/show_bug.cgi?id=1942914#c20
    

Will consider add more versioned CPU models gradually in future instead of adding them all once in case there is any bad regression issue.

FEEDBACK from Developer

And normally CPU features cannot change because if they do, things are going to break upon migration, e.g. a feature may suddenly appear or disappear. When we need to change features, we introduce a new version of a CPU model, see e.g Skylake-Server-noTSX-IBRS, Skylake-Server-v5 and so on. We need to guarantee the guest ABI compatibility.

@nanliu-r
Copy link
Contributor Author

nanliu-r commented Sep 29, 2024

Test PASS on following hardware products.
AMD:

  1. EPYC
  2. EPYC-Rome
  3. EPYC-Milan
  4. EPYC-Genoa

Intel:

  1. Icelaker Server
  2. Cooperlake
  3. Sapphire Rapids

Test scenarios covering RHEL and Windows VM.

  • x86_cpu_model
  • x86_cpu_flags
  • cpu_device_hotpluggable

@PaulYuuu @luckyh @yanan-fu Please help review this patch, thanks!

Copy link
Contributor

@yanan-fu yanan-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Yanan Fu yfu@redhat.com

@luckyh luckyh merged commit e69c15e into avocado-framework:master Sep 29, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants