-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove tesnet flows #498
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the upload tmpnet files step just needs to be fixed
deferring for now to fully handle removing #498 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification with removal of interfaces and resulting shrinking of the utils file.
FWIW I didn't mind the earlier commit you had with n
instead of localnetwork
either but this works too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, just one request to put the LocalNetwork
methods all in the same place.
Why this should be merged
Removes testnet e2e flows that we don't use and is extra burden to maintain. Mostly will rely on local network e2e tests, only main difference with testing on testnet is the difference in the networks, so confirming in manual deployments of Teleporter's interaction with Warp and network validators should cover
How this works
still leaves e2e test that allow for non local networks being passed. Might be useful when we want to manually set up testnet testing.
How this was tested
How is this documented