Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9042: light/dark mode #2014

Merged
merged 5 commits into from
Oct 25, 2024
Merged

CP-9042: light/dark mode #2014

merged 5 commits into from
Oct 25, 2024

Conversation

onghwan
Copy link
Contributor

@onghwan onghwan commented Oct 25, 2024

Description

Ticket: CP-9042

  • implement light/dark mode in the redesigned app
  • implement light/dark mode in the storybook for k2-alpine

Screenshots/Videos

App

Screen.Recording.2024-10-25.at.1.10.30.PM.mov

Storybook

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-25.at.13.12.59.mp4

Checklist

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

packages/k2-alpine/App.tsx Outdated Show resolved Hide resolved
DripsySafeAreaView,
{}
)({
backgroundColor: '$surfacePrimary'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice adjustment

Copy link
Collaborator

@atn4z7 atn4z7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto!!

@onghwan onghwan merged commit b2d8f35 into main Oct 25, 2024
4 checks passed
@onghwan onghwan deleted the CP-9042 branch October 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants