Fix connected weight calculation #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-test Add test for calculating connected weight bugfix
geoff-vball
approved these changes
Oct 17, 2024
|
@iansuvak thank you for looping back to add the tests here 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It looks like the way that the relayer was previously calculating the
connectedWeightis incorrect. TheWeightfor each validator returned byGetCurrentCanonicalValidatorSetis the total weight for all node IDs with a given BLS key. When summing the weight by iterating over connected node IDs then, we would be double counting in any situation where multiple node IDs were using the same BLS key.How this works
Checks if a node ID with the given BLS key have been accounted for already.
How this was tested
TODO
How is this documented
N/A