Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vIOMMU: Add a test about driver load/unload #5945

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vIOMMU: Add a test about driver load/unload #5945

wants to merge 1 commit into from

Conversation

Yingshun
Copy link
Contributor

@Yingshun Yingshun commented Oct 22, 2024 •
edited
Loading

This PR adds:
VIRT-301883 - [vIOMMU] Test driver load/unload (disable/enable)

Test results:

aarch64:
 (1/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.virtio: PASS (82.89 s)
 (2/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.smmuv3: PASS (74.05 s)
 (3/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.virtio: PASS (94.98 s)
 (4/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.smmuv3: PASS (73.13 s)
RESULTS    : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2024-10-21T21.11-1e32ed4/results.html

x86_64:
 (1/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.virtio: STARTED
 (1/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.virtio: PASS (284.50 s)
 (2/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.intel: STARTED
 (2/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_on.intel: PASS (766.48 s)
 (3/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.virtio: STARTED
 (3/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.virtio: PASS (219.00 s)
 (4/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.intel: STARTED
 (4/4) type_specific.io-github-autotest-libvirt.vIOMMU.unload_driver.virtio_interface.vhost_off.intel: PASS (448.50 s)
RESULTS    : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2024-10-22T02.53-f8457bf/results.html

@Yingshun
vIOMMU: Add a test about driver load/unload
855e516 
This PR adds:
    VIRT-301883 - [vIOMMU] Test driver load/unload (disable/enable)

Signed-off-by: Yingshun Cui <yicui@redhat.com>
@Yingshun Yingshun requested a review from chloerh October 25, 2024 05:41
cliping
cliping reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

libvirt/tests/cfg/sriov/vIOMMU/viommu_unload_driver.cfg
variants:
- virtio:
only q35, aarch64
func_supported_since_libvirt_ver = (8, 3, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing libvirt_version.is_libvirt_feature_supported() in py file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's covered by test_obj = viommu_base.VIOMMUTest(vm, test, params).

@Yingshun Yingshun requested a review from cliping October 25, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliping cliping cliping approved these changes

@chloerh chloerh Awaiting requested review from chloerh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yingshun @cliping