Add preliminary support for the OTP socket interface #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadushin
force-pushed
the
otp-socket-resource
branch
from
1b7f7ae
to
32962aa
Compare
pguyot
reviewed
Aug 16, 2023
fadushin
force-pushed
the
otp-socket-resource
branch
4 times, most recently
from
704db5f
to
db1f7f2
Compare
pguyot
reviewed
Aug 25, 2023
fadushin
force-pushed
the
otp-socket-resource
branch
from
db1f7f2
to
da6ca88
Compare
fadushin
force-pushed
the
otp-socket-resource
branch
2 times, most recently
from
75a4d79
to
0e807ca
Compare
pguyot
reviewed
Sep 14, 2023
fadushin
force-pushed
the
otp-socket-resource
branch
3 times, most recently
from
059ee51
to
3fdf221
Compare
fadushin
force-pushed
the
otp-socket-resource
branch
5 times, most recently
from
ddae90d
to
13514ab
Compare
fadushin
force-pushed
the
otp-socket-resource
branch
2 times, most recently
from
67a938b
to
a45aa10
Compare
fadushin
force-pushed
the
otp-socket-resource
branch
2 times, most recently
from
a525145
to
3b219be
Compare
pguyot
approved these changes
Oct 13, 2023
fadushin
force-pushed
the
otp-socket-resource
branch
from
956f50e
to
82873dd
Compare
bettio
requested changes
Oct 16, 2023
fadushin
force-pushed
the
otp-socket-resource
branch
from
82873dd
to
2f74f64
Compare
This PR adds preliminary support for the OTP socket interface, which exposes APIs for low-level socket operations, as defined in OTP 22 and later. This implementation aims to be API-compatible with the OTP implementation, though many parts of the interface have yet to be implemented. Key features of this implementation include the following: * A new socket driver has been added, which uses the BSD socket interface to implement the OTP socket driver * This driver is supported on generic UNIX and ESP32 platforms. Where possible, a common codebase is used, to minimize the cost of maintenance. The following operations are supported: * socket:open/3 * socket:close/1 * socket:bind/2 * socket:listen/1,2 * socket:accept/1 * socket:sockname/1 * socket:peername/1 * socket:recv/1 * socket:recvfrom/1 * socket:send/2 * socket:sendto/3 * socket:setopt/3 * socket:connect/2 * socket:shutdown/2 Currently, the TCP and UDP protocols is supported. Additional work is needed to support other data types and protocols, as well as name resolution via the OTP net:addrinfo interface. Signed-off-by: Fred Dushin <fred@dushin.net>
fadushin
force-pushed
the
otp-socket-resource
branch
from
2f74f64
to
8e2d42f
Compare
UncleGrumpy
reviewed
Oct 22, 2023
bettio
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary support for the OTP socket interface, which exposes APIs for low-level socket operations, as defined in OTP 22 and later. This implementation aims to be API-compatible with the OTP implementation, though many parts of the interface have yet to be implemented.
Key features of this implementation include the following:
The following operations are supported:
Currently, the TCP and UDP protocols is supported. Additional work is needed to support other data types and protocols, as well as name resolution via the OTP net:addrinfo interface.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later