Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SMP for emscripten #695

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Jul 20, 2023

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot
Copy link
Collaborator Author

pguyot commented Jul 21, 2023

CI doesn’t pass for node.

@pguyot pguyot marked this pull request as draft July 21, 2023 04:37
@pguyot pguyot force-pushed the w29/emscripten-enable-smp branch from b619ec3 to ddce32c Compare July 21, 2023 06:51
@pguyot
Copy link
Collaborator Author

pguyot commented Jul 21, 2023

CI doesn’t pass for node.

Actually, it was flappy.
I just force pushed a fix.

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot
Copy link
Collaborator Author

pguyot commented Aug 5, 2023

Tests pass locally and CI passed three times in a row after rebasing and fixing conflicts, so let's mark this ready for review.

@pguyot pguyot marked this pull request as ready for review August 5, 2023 20:42
@bettio bettio merged commit bee9ef3 into atomvm:master Aug 5, 2023
71 checks passed
@pguyot pguyot deleted the w29/emscripten-enable-smp branch August 6, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants