This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Implement naming conventions in template theme #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2020
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
047f477
to
c718233
Compare
This was referenced Jan 12, 2021
sadick254
pushed a commit
to atom/atom
that referenced
this pull request
Feb 19, 2021
Update of the default syntax themes to implement [naming conventions](atom/flight-manual.atom.io#564) for syntax scopes. Adds the [template](atom/apm#883) to each theme with custom colors, to accommodate the naming conventions. There should be no compatibility break with existing grammars. As naming conventions are implemented in more language grammars, their old specific stylesheets can be retired.
aminya
approved these changes
Feb 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a rewrite of the template theme to implement naming conventions for syntax scopes.
Benefits
The naming conventions really shine through in this PR. Simply filling out the template is enough to ensure coherent highlighting across languages. This is what the original template tried to achieve, but without clear naming conventions, the resulting syntax highlighting was too inconsistent. The most notable improvements are on punctuation and types.
Possible Drawbacks
Some additional scopes absent from old grammars, but besides that no obvious incompatibilities, most scopes stay the same. PRs to make grammars fully compatible are linked below.
Applicable Issues
Related Pull Requests