Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft recommended products #75

Merged
merged 0 commits into from
May 13, 2024
Merged

Ft recommended products #75

merged 0 commits into from
May 13, 2024

Conversation

elijahladdie
Copy link
Contributor

@elijahladdie elijahladdie commented May 12, 2024 •
edited
Loading

#69

@elijahladdie elijahladdie added this to the Product Management milestone May 12, 2024
@elijahladdie elijahladdie linked an issue May 12, 2024 that may be closed by this pull request
Feat: Buyer should be able to see recommended products #69
Closed
@elijahladdie elijahladdie added backend Good for newcomers In Progress This Label will be added on pending task labels May 12, 2024
@elijahladdie elijahladdie self-assigned this May 12, 2024
@elijahladdie elijahladdie force-pushed the ft-recommended-products branch 6 times, most recently from ba31222 to 5160240 Compare May 13, 2024 06:31
@faid-terence
Copy link
Collaborator

@elijahladdie !
Please write a proper PR description following best practices

@faid-terence
Copy link
Collaborator

Also squash the commit messages , they shouldn't exceed two !

@elijahladdie elijahladdie force-pushed the ft-recommended-products branch 3 times, most recently from ffdb006 to e817309 Compare May 13, 2024 17:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9067246103

Details

  • 397 of 437 (90.85%) changed or added relevant lines in 28 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 78.901%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/middlewares/multer.ts 7 8 87.5%
src/services/updateUserStatus/activateUserService.ts 16 17 94.12%
src/services/updateUserStatus/deactivateUserService.ts 16 17 94.12%
src/middlewares/isAllowed.ts 15 17 88.24%
src/middlewares/verifyToken.ts 21 26 80.77%
src/services/userServices/userProfileUpdateServices.ts 19 24 79.17%
src/services/productServices/createProduct.ts 47 53 88.68%
src/services/productServices/getRecommendedProductsService.ts 25 31 80.65%
src/services/productServices/updateProduct.ts 49 55 89.09%
src/services/userServices/sendResetPasswordLinkService.ts 11 18 61.11%
Files with Coverage Reduction New Missed Lines %
src/controllers/authController.ts 1 97.06%
src/utils/sendStatusMail.ts 1 81.25%
Totals Coverage Status
Change from base Build 9052889769: -0.4%
Covered Lines: 806
Relevant Lines: 947
💛 - Coveralls

@elijahladdie elijahladdie merged commit e817309 into develop May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elijahladdie elijahladdie

Labels
backend Good for newcomers In Progress This Label will be added on pending task
Projects
None yet
Milestone
Product Management
Development

Successfully merging this pull request may close these issues.

Feat: Buyer should be able to see recommended products
3 participants
@elijahladdie @faid-terence @coveralls