-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: signin a user with email and password #53
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10624400 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624400 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624401 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624401 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624402 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624402 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624403 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
10624403 | Triggered | Generic Password | d46968c | src/test/signin.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@Ndevu12 !!What's the progres ? |
Sorry I forgot to send JWT_SECRET_KEY.
But you can find it on slack now.
…On Thu, May 2, 2024 at 11:44 PM Terence Faid JABO ***@***.***> wrote:
@Ndevu12 <https://github.com/Ndevu12> !!What's the progres ?
—
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBQ2IHIN2I4XHKYTWUHA6ODZAKXT3AVCNFSM6AAAAABHD3BXKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRG44DENJXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Ndevu12 ! |
@faid-terence |
be80e47
to
40ef364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge this PR !, Please squash commit messages !
Now we have one commit |
Pull Request Test Coverage Report for Build 8935890322Details
💛 - Coveralls |
Description
This PR introduces a new feature that allows users to sign in using their email and password.
Also it Implement error handling for cases where the user tries to sign in with an invalid email or password.
Changes
Test Plan