Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename private_attributes -> private on swagger #160

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Rename private_attributes -> private on swagger #160

merged 1 commit into from
Jul 30, 2024

Conversation

italovalcy
Copy link
Contributor

@italovalcy italovalcy commented Jul 30, 2024 •
edited
Loading

Rename Topology.Node.Port.private_attributes to private, which was left behind.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10154164359

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.056%
Totals Coverage Status
Change from base Build 10153259955: 0.0%
Covered Lines: 1221
Relevant Lines: 1500
💛 - Coveralls

@italovalcy italovalcy marked this pull request as ready for review July 30, 2024 00:51
@italovalcy italovalcy merged commit 40317d5 into main Jul 30, 2024
9 checks passed
@italovalcy italovalcy deleted the rename_private_attr branch July 30, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

@YufengXin YufengXin Awaiting requested review from YufengXin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@italovalcy @coveralls @congwang09