Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error when unreserve_vlan() can't find the request ID #222

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Raise an error when unreserve_vlan() can't find the request ID #222

merged 7 commits into from
Aug 30, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 29, 2024

Resolves #180. This will need additional exception handling in SDX Controller.

@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10623797978

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 88.634%
Totals Coverage Status
Change from base Build 10619541162: 0.08%
Covered Lines: 1125
Relevant Lines: 1247
💛 - Coveralls

@sajith sajith merged commit 40bfe1b into main Aug 30, 2024
11 checks passed
@sajith sajith deleted the 180.unreserve-error-no-request-id branch August 30, 2024 13:37
@sajith sajith self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@congwang09 congwang09 Awaiting requested review from congwang09

Assignees

@sajith sajith

Labels
None yet
Projects
@sajith's project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return error when unreserve_vlan() can't find connection request ID
3 participants
@sajith @coveralls @YufengXin