Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 212 #213

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix/issue 212 #213

merged 1 commit into from
Aug 17, 2024

Conversation

italovalcy
Copy link
Contributor

Fix #212

Description of the change

As described on issue #212, the _port_node_map is used to create interdomain links and to compute VLAN Table. It happened that _port_node_map was being updated only when topology_add() was called. This pull request adds the update of the _port_node_map to be executed also when the topology is updated. That way, new nodes, new ports, changed IDs, etc. all get reflected on the port node map.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10351010481

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 86.318%

Totals Coverage Status
Change from base Build 10351001082: 0.05%
Covered Lines: 1124
Relevant Lines: 1282

💛 - Coveralls

@italovalcy italovalcy requested review from congwang09, sajith and YufengXin and removed request for sajith, YufengXin and congwang09 August 16, 2024 08:25
@italovalcy italovalcy merged commit dfd4205 into main Aug 17, 2024
11 checks passed
@italovalcy italovalcy deleted the fix/issue_212 branch August 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update port node map when topology is updated rather than only when topology is added
3 participants