Fix/issue 212 #213
Merged
Fix/issue 212 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10351010481Details
💛 - Coveralls |
italovalcy
requested review from
congwang09,
sajith and
YufengXin
and removed request for
sajith,
YufengXin and
congwang09
YufengXin
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #212
Description of the change
As described on issue #212, the
_port_node_mapis used to create interdomain links and to compute VLAN Table. It happened that_port_node_mapwas being updated only when topology_add() was called. This pull request adds the update of the_port_node_mapto be executed also when the topology is updated. That way, new nodes, new ports, changed IDs, etc. all get reflected on the port node map.