Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make PCE minimally compatible with topology spec 2.0.0 #197

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

italovalcy
Copy link
Contributor

Fix #196

Description of the change

This pull request propose some changes on PCE TopologyManager component to make it comply with Topology Data Model Spec 2.0.0, specially for the inter domain computation.

Other changes will be needed in the near future to make it fully comply with spec 2.0.0 (e.g., private attributes, etc)

@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 10101444696

Details

  • 50 of 50 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 85.131%

Files with Coverage Reduction New Missed Lines %
src/sdx_pce/topology/manager.py 1 90.75%
Totals Coverage Status
Change from base Build 9813203140: 0.6%
Covered Lines: 1094
Relevant Lines: 1260

💛 - Coveralls

@italovalcy italovalcy marked this pull request as ready for review July 25, 2024 21:06
@YufengXin
Copy link
Collaborator

Note: (1) port.id; (2) port.nni for inter-domain links

@italovalcy italovalcy merged commit 69e047d into main Jul 26, 2024
11 checks passed
@italovalcy italovalcy deleted the fix/issue_196 branch July 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New topology data model spec defines Link object with a list of string representing port ids
4 participants