add a method:TEManager.add_breakdowns_to_connection(connection_reques… #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9288976337Details
💛 - Coveralls |
congwang09
approved these changes
May 29, 2024
sajith
approved these changes
May 29, 2024
src/sdx_pce/topology/temanager.py
Outdated
Comment on lines
411
to
414
| def add_breakdowns_to_connection(self, connection_request: dict, breakdowns: dict): | ||
| connection_request["breakdowns"] = breakdowns | ||
|
|
||
| return connection_request |
There was a problem hiding this comment.
Can we add a docstring here? The purpose of this method is not immediately obvious... I will likely wonder what this was about after a couple of months or weeks. :-)
There was a problem hiding this comment.
I agree-:). (1) the whole purpose is to associate the connect request with its computed breakdowns so sdx-controller can remember(2) I think this method might be absorbed by the pce.generate_connection_breakdown(), but I don't want to change any existing methods for . so this... when you work on unreserve_vlan workflow, feel free to change it if needed.
YufengXin
deleted the
187-add-breakdowns-to-the-connection-object-as-an-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t, breakdown)
to address the "send breakdowns to PCs when deleting a connection.