-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a method:TEManager.add_breakdowns_to_connection(connection_reques… #188
add a method:TEManager.add_breakdowns_to_connection(connection_reques… #188
Conversation
Pull Request Test Coverage Report for Build 9288976337Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the nagging feeling that there must be a nicer way to do this, but I have not thought long enough or hard enough about what that way might be...
src/sdx_pce/topology/temanager.py
Outdated
def add_breakdowns_to_connection(self, connection_request: dict, breakdowns: dict): | ||
connection_request["breakdowns"] = breakdowns | ||
|
||
return connection_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a docstring here? The purpose of this method is not immediately obvious... I will likely wonder what this was about after a couple of months or weeks. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree-:). (1) the whole purpose is to associate the connect request with its computed breakdowns so sdx-controller can remember(2) I think this method might be absorbed by the pce.generate_connection_breakdown(), but I don't want to change any existing methods for . so this... when you work on unreserve_vlan workflow, feel free to change it if needed.
…t, breakdown)
to address the "send breakdowns to PCs when deleting a connection.