-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove topologymanager module #80
Conversation
The drop in coverage is due to honesty :-) Previously reported coverage was measuring coverage of tests (see https://coveralls.io/builds/55212972), which is meaningless. With some changes in |
where does it (topologymanger) go?-:) is it ready to use in pre? thanks |
It was moved to pce, in atlanticwave-sdx/pce#96, and I'm making some more changes in atlanticwave-sdx/pce#98 (mainly error handling and some refactoring). So sdx-controller will use The reason for this set of changes is stated in atlanticwave-sdx/pce#95. Basically, some classes were added to represent connection requests and solutions in pce (instead of plain old arrays and dicts), and topology-related classes can share that code easily if we move them to pce. |
Thanks. I asked because I need to add some code to take care of the vlan reservation for every path. They're mostly done in my own branch. I will find the right place to add. |
Thanks. Should have made this change earlier on. Sorry about the hold up! |
Issue is #79: this module is being moved to pce, in atlanticwave-sdx/pce#98.