Add simple mocked response object to httpResponse property on ResultMockFactory #1776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am writing some tests using the
ResultMockFactory
on theSsmClient
. This all works great but as part of the application code we are calling the following method on the result mock class.This goes through to the
info()
method on theAsyncAws\Core\Response
class where thehttpResponse
property is null, so the test then attempts to callgetInfo()
on null.I have been following https://async-aws.com/features/tests.html and I have tried to figure out if I can add the response data in any other way but I can't see this being possible.
So I have set the
SimpleMockedResponse
object as thehttpResponse
property on the class and it now returns 200 as expected. I felt this was the most appropriate class to use, but I may be wrong.