[package] Update memjs to 0.10.0. #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version we were using had an issue where too many timeout handlers were being defined: memcachier/memjs#86. This lead to many warnings like the following in the production logs: (node:9852) Warning: Possible EventEmitter memory leak detected. 11 timeout listeners added. Use emitter.setMaxListeners() to increase limit The logs also show many `ECONNRESET` and similar errors, which may be related to this: memcachier/memjs#89. According to that thread, however, it seems like version 0.10.0 could also be suffering from issues, although others report it working for them.
|
Right now I don’t think this will actually fix the memory leak, I’m just trying to get rid of the noise and potential red 🐟s. If this does not fix the many connection resets, we might have to downgrade to 0.9.0, which is the version that was being used prior to the switch to yarn. |
|
Nice! Thanks for the detective work. It's a good start 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version we were using had an issue where too many timeout handlers
were being defined: memcachier/memjs#86.
This lead to many warnings like the following in the production logs:
The logs also show many
ECONNRESETand similar errors, which may berelated to this: memcachier/memjs#89. According to
that thread, however, it seems like version 0.10.0 could also be
suffering from issues, although others report it working for them.