Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ligero univariate and multilinear PCS #132

Merged
merged 68 commits into from
Oct 25, 2024

Conversation

mmagician
Copy link
Member

Description

Supersedes #125: we have refactored our original (univariate) Ligero codebase to support other linear code PC schemes (multilinear Ligero, Brakedown). This requires the implementers of new linear code schemes to implement LinearEncode and LinCodeParametersInfo, where most methods are trivial and the core logic contained in encode. Perhaps there's some simplifications to be done to the traits still.

closes: #125


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Antonio95 and others added 2 commits October 25, 2023 10:04
Co-authored-by: Hossein Moghaddas <autquis@gmail.com>
Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
@mmagician mmagician requested a review from a team as a code owner October 25, 2023 10:20
@mmagician mmagician requested review from z-tech, Pratyush and weikengchen and removed request for a team October 25, 2023 10:20
@Pratyush Pratyush added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@Pratyush Pratyush added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 25, 2024
@autquis autquis mentioned this pull request Oct 25, 2024
6 tasks
@autquis
Copy link
Contributor

autquis commented Oct 25, 2024

This PR is ready now!

@Pratyush Pratyush added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@autquis
Copy link
Contributor

autquis commented Oct 25, 2024

Hmm, I think the last commit fixes the issue with the CI. I'm not sure why it did not appear earlier on. 🤔
Sorry!

Edit: It seems to be a network failure!

@Pratyush Pratyush added this pull request to the merge queue Oct 25, 2024
Merged via the queue into arkworks-rs:master with commit 78aa1d7 Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants