Feat(eos_designs): Add option to disable default 'redistribute connected' in VRF. #4220
+847
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4220
# Activate the virtual environment
source test-avd-pr-4220/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@issue4091#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,issue4091 --force
# Optional: Install AVD examples
cd test-avd-pr-4220
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
changed the title
github-actions
bot
added
state: CI Updated
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Jul 22, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jul 26, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
issue4091
branch
from
f0b1eb7
to
d8650dc
Compare
ClausHolbechArista
approved these changes
Jul 26, 2024
ClausHolbechArista
added
the
one approval
gmuloc
requested changes
Jul 26, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jul 26, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
removed
the
one approval
github-actions
bot
added
type: documentation
laxmikantchintakindi
force-pushed
the
issue4091
branch
from
1bb67dd
to
d912e44
Compare
github-actions
bot
removed
type: documentation
laxmikantchintakindi
force-pushed
the
issue4091
branch
from
d912e44
to
1f68379
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
force-pushed
the
issue4091
branch
from
98b21cc
to
bfbee2d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
approved these changes
Oct 10, 2024
gmuloc
added
the
one approval
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add option to disable default 'redistribute connected ' in VRF.
Related Issue(s)
Fixes #4091
Component(s) name
arista.avd.eos_designsProposed changes
Add option to disable default 'redistribute connected ' in VRF. MPLS topology . Customer does not want to see connected routes in RT.
How to test
Checklist
User Checklist
Repository Checklist