dont require migration dirs from github to run extenstion #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseelch
reviewed
Oct 19, 2023
prompt.go
Outdated
Comment on lines
23
to
42
| switch { | ||
| case i.DirPath == "" && len(dirs) == 0: | ||
| prompt := promptui.Prompt{ | ||
| Label: "Enter the path of the migration directory in your repository", | ||
| Stdin: i.stdin, | ||
| } | ||
| if i.DirPath, err = prompt.Run(); err != nil { | ||
| return err | ||
| } | ||
| case i.DirPath == "" && len(dirs) > 0: | ||
| opts := append(dirs, "provide another path") | ||
| prompt := promptui.Select{ | ||
| Label: "Choose migration directory", | ||
| Items: dirs, | ||
| Items: opts, | ||
| Stdin: i.stdin, | ||
| } | ||
| if _, i.DirPath, err = prompt.Run(); err != nil { | ||
| return err | ||
| } | ||
| prompt = promptui.Select{ | ||
| Label: "Choose driver", | ||
| Items: []string{"mysql", "postgres", "mariadb", "sqlite"}, | ||
| } |
There was a problem hiding this comment.
You can move that switch into the upper if since all cases require i.DirPath to be zero.
masseelch
previously approved these changes
Oct 19, 2023
masseelch
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo without migration dir:
repo with migration dir:
Screen.Recording.2023-10-19.at.14.05.58.mov