Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit-comment benchmark comparison #862

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Nov 7, 2023

Alternate idea to #861: trades a bit of parsing for getting the PR number in the commit-comment, which might be nice for easy lookup.

Note: Because criterion-table parses by /, this solution will likely be buggy when attempting to merge into a non-default base branch with a / character (e.g. sb/base-branch will be truncated by criterion-table into fib-branch=sb).

Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VERGEN_GIT_BRANCH has content that's :

  • resolved to gh-merge-queue in merge_group,
  • likely to shift / not lead to reproducible builds, and I expect folks to demand precise pointers to code.

Same goes for the PR number.

@huitseeker huitseeker closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants