ci: fix GPU benches #857
Merged
ci: fix GPU benches #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/lurk-lab/lurk-rs/actions/runs/6773544195/job/18408644257 This resulted in: ``` thread 'main' panicked at benches/fibonacci_lem.rs:67:33: not yet implemented ``` This makes sure the `todo!()` at this line is no longer there to be found.
porcuquine
approved these changes
Nov 6, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#852 broke GPU benches
https://github.com/lurk-lab/lurk-rs/actions/runs/6773544195/job/18408644257
This results in :
This PR collapses the
gh-pagesjob into the default case, making sure the unimplemented at this line isn't there to hit.