Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set up clippy to avoid creeping annotations #602

Merged
merged 8 commits into from
Aug 17, 2023

Commits on Aug 16, 2023

  1. refactor: Standardize linting rules

    - Removed split linting warnings across multiple files, removing clippy::too_many_arguments allowances
    - Modified the clippy lint settings, denying previously allowed lints, and used config to enforce prior behavior
    huitseeker committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    afa03ff View commit details
    Browse the repository at this point in the history
  2. chore: Error on clippy::cast_lossless

    This fires when there is a guaranteed lossless type conversion that could replace a cast.
    huitseeker committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ef36337 View commit details
    Browse the repository at this point in the history
  3. refactor: Add and fix rust_2018_idioms lint

    - Corrected lifetime specifications in `BenchmarkGroup` for all benchmarking functions in `fibonacci.rs` and `synthesis.rs`.
    - Added `-Wrust_2018_idioms` lint to the `xclippy` alias in the `.cargo` config, and removed thenredundant `rust_2018_idioms` from the deny lint attributes in the library root.
    huitseeker committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4e2bb2e View commit details
    Browse the repository at this point in the history
  4. refactor: derive Eq trait across various structs and types + enforc…

    …e this with cargo
    
    - Adds the `Eq` trait to derive macros a series of data structures across multiple files,
    - Strictened linting rules by implementing a new clippy lint check for unpaired `PartialEq` and `Eq` derivations,
    huitseeker committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    dd440f9 View commit details
    Browse the repository at this point in the history
  5. chore: reject large types passed by value

    - Lint is designed to identify and flag instances of large types being passed by value
    huitseeker committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3c5db0c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. chore: Add a couple of (respected) lints

    - Incorporates lint checks for specific behaviors including needless borrows, misuse of ok_or, and unused lifetimes.
    
    chore: set up checked conversions lint
    huitseeker committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    db3d8e2 View commit details
    Browse the repository at this point in the history
  2. chore: set up inefficient_to_string lint

    - Implement an update to the `to_string()` function usage in `init_lurk_state` for efficiency.
    - Modify the creation of hex strings in `parse_unicode` for efficiency.
    - Include `inefficient_to_string` lint checker
    huitseeker committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    70c19bf View commit details
    Browse the repository at this point in the history
  3. refactor: refactor and set up Option / Result iteration lints

    - Enhanced Rust's Clippy linting capabilities by adding four new lints: `filter_map_next`, `flat_map_option`, `map_flatten`, and `map_unwrap_or` in `.cargo/config` file.
    huitseeker committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5f405f5 View commit details
    Browse the repository at this point in the history