-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set up clippy to avoid creeping annotations #602
Commits on Aug 16, 2023
-
refactor: Standardize linting rules
- Removed split linting warnings across multiple files, removing clippy::too_many_arguments allowances - Modified the clippy lint settings, denying previously allowed lints, and used config to enforce prior behavior
Configuration menu - View commit details
-
Copy full SHA for afa03ff - Browse repository at this point
Copy the full SHA afa03ffView commit details -
chore: Error on clippy::cast_lossless
This fires when there is a guaranteed lossless type conversion that could replace a cast.
Configuration menu - View commit details
-
Copy full SHA for ef36337 - Browse repository at this point
Copy the full SHA ef36337View commit details -
refactor: Add and fix rust_2018_idioms lint
- Corrected lifetime specifications in `BenchmarkGroup` for all benchmarking functions in `fibonacci.rs` and `synthesis.rs`. - Added `-Wrust_2018_idioms` lint to the `xclippy` alias in the `.cargo` config, and removed thenredundant `rust_2018_idioms` from the deny lint attributes in the library root.
Configuration menu - View commit details
-
Copy full SHA for 4e2bb2e - Browse repository at this point
Copy the full SHA 4e2bb2eView commit details -
refactor: derive
Eq
trait across various structs and types + enforc……e this with cargo - Adds the `Eq` trait to derive macros a series of data structures across multiple files, - Strictened linting rules by implementing a new clippy lint check for unpaired `PartialEq` and `Eq` derivations,
Configuration menu - View commit details
-
Copy full SHA for dd440f9 - Browse repository at this point
Copy the full SHA dd440f9View commit details -
chore: reject large types passed by value
- Lint is designed to identify and flag instances of large types being passed by value
Configuration menu - View commit details
-
Copy full SHA for 3c5db0c - Browse repository at this point
Copy the full SHA 3c5db0cView commit details
Commits on Aug 17, 2023
-
chore: Add a couple of (respected) lints
- Incorporates lint checks for specific behaviors including needless borrows, misuse of ok_or, and unused lifetimes. chore: set up checked conversions lint
Configuration menu - View commit details
-
Copy full SHA for db3d8e2 - Browse repository at this point
Copy the full SHA db3d8e2View commit details -
chore: set up inefficient_to_string lint
- Implement an update to the `to_string()` function usage in `init_lurk_state` for efficiency. - Modify the creation of hex strings in `parse_unicode` for efficiency. - Include `inefficient_to_string` lint checker
Configuration menu - View commit details
-
Copy full SHA for 70c19bf - Browse repository at this point
Copy the full SHA 70c19bfView commit details -
refactor: refactor and set up Option / Result iteration lints
- Enhanced Rust's Clippy linting capabilities by adding four new lints: `filter_map_next`, `flat_map_option`, `map_flatten`, and `map_unwrap_or` in `.cargo/config` file.
Configuration menu - View commit details
-
Copy full SHA for 5f405f5 - Browse repository at this point
Copy the full SHA 5f405f5View commit details