chore: encapsulate sparse API #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Mar 3, 2024
| .map(|ptrs| RowData::ref_cast(ptrs.try_into().unwrap())) | ||
| } | ||
|
|
||
| /// Retrieves the data for row slice [i..j] from `row`. |
There was a problem hiding this comment.
It would be good to document that ths returned usize is a column index.
| /// Wrapper type for encode rows of [`SparseMatrix`] | ||
| #[derive(Debug, Clone, RefCast)] | ||
| #[repr(transparent)] | ||
| pub struct RowData([usize; 2]); |
There was a problem hiding this comment.
This isn't really RowData, is it, rather RowIndexes, right?
huitseeker
approved these changes
Mar 7, 2024
|
!benchmark --bench recursive-snark --features cuda |
|
|
|
!benchmark --bench recursive-snark --features cuda |
Benchmark for 07f571eClick to view benchmark
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to clean up the sparse matrix API, so that manipulating the rows is clear.