Revert "chore: Run dex reverse proxy only when dex is configured (#7999)" #8291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oproj#7999)" This reverts commit 303cc46. Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
8221-oidc-stopped-working
branch
from
180c60c
to
0149e50
Compare
Codecov Report
@@ Coverage Diff @@
## master #8291 +/- ##
=======================================
Coverage 41.93% 41.93%
=======================================
Files 176 176
Lines 22992 22992
=======================================
Hits 9641 9641
Misses 11966 11966
Partials 1385 1385
Continue to review full report at Codecov.
|
kshamajain99
approved these changes
Jan 27, 2022
pasha-codefresh
pushed a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Feb 2, 2022
…oproj#7999)" (argoproj#8291) This reverts commit 303cc46. Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 303cc46.
Closes #8221
Due to changes of #7999 the
registerDexHandlersmethod exists early. Hoverver this method registers handles for both Dex and OIDC login. Reverting this PR for now to restored OIDC functionality