Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompting to confirm project role deletion #20613

Conversation

pasha-codefresh
Copy link
Member

Related to: #19528

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner October 31, 2024 10:55
Copy link

bunnyshell bot commented Oct 31, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 55.12%. Comparing base (e861b55) to head (1382576).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/project_role.go 0.00% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20613      +/-   ##
==========================================
- Coverage   55.16%   55.12%   -0.04%     
==========================================
  Files         324      324              
  Lines       55139    55185      +46     
==========================================
+ Hits        30415    30420       +5     
- Misses      22099    22156      +57     
+ Partials     2625     2609      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: pashakostohrys <pavel@codefresh.io>
@ishitasequeira ishitasequeira enabled auto-merge (squash) October 31, 2024 13:26
@ishitasequeira ishitasequeira merged commit 8a4e7e0 into argoproj:master Oct 31, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants