Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): missing selected ALPN property #20579

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Oct 29, 2024

With the dependency update (#19229), we included grpc/grpc-go#7769 and are now getting the following when using TLS:

Unable to load data: connection error: desc = "transport: authentication handshake failed: credentials: cannot check peer: missing selected ALPN property"

A possible workaround is to kustomize patch the argocd-server Deployment to add

apiVersion: apps/v1
kind: Deployment
metadata:
  name: argocd-server
spec:
  template:
    spec:
      containers:
        - name: argocd-server
          env:
            - name: GRPC_ENFORCE_ALPN_ENABLED
              value: 'false'

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Copy link

bunnyshell bot commented Oct 29, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault marked this pull request as ready for review October 29, 2024 22:21
@agaudreault agaudreault requested a review from a team as a code owner October 29, 2024 22:21
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (ec499bb) to head (c6b6659).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
server/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20579      +/-   ##
==========================================
+ Coverage   55.07%   55.19%   +0.11%     
==========================================
  Files         322      324       +2     
  Lines       54927    55114     +187     
==========================================
+ Hits        30253    30422     +169     
- Misses      22068    22084      +16     
- Partials     2606     2608       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit a7637cd into argoproj:master Oct 31, 2024
32 checks passed
@agaudreault agaudreault deleted the alpn-error branch October 31, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants